Skip to content

fix(no-ignored-error): check observer object too #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix(no-ignored-error): check observer object too #27

merged 1 commit into from
Nov 16, 2024

Conversation

JasonWeinzierl
Copy link
Owner

Fixes lack of error when passing an observer object into subscribe that's lacking an error property. Previously this rule would only fire if passing in separate callbacks.

Resolves upstream cartant#94

@github-actions GitHub Actions
Copy link

LCOV of commit 52e2539 during .github/workflows/ci.yml #94

Summary coverage rate:
  lines......: 96.3% (3425 of 3555 lines)
  functions..: 95.1% (215 of 226 functions)
  branches...: 91.6% (674 of 736 branches)

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/rules/no-ignored-error.ts          |98.6%     72| 100%     6|95.2%     21

@JasonWeinzierl JasonWeinzierl added the bug Something isn't working label Nov 16, 2024
@JasonWeinzierl JasonWeinzierl merged commit 46e105f into main Nov 16, 2024
2 checks passed
@JasonWeinzierl JasonWeinzierl deleted the check-observer-too branch November 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JasonWeinzierl